Skip to content
Snippets Groups Projects
Unverified Commit 0ff487b8 authored by Miss Islington (bot)'s avatar Miss Islington (bot) Committed by GitHub
Browse files

bpo-44287: asyncio test_popen() uses longer timeout (GH-26832)



Fix asyncio test_popen() of test_windows_utils by using a longer
timeout. Use military grade battle-tested test.support.SHORT_TIMEOUT
timeout rather than a hardcoded timeout of 10 seconds: it's 30
seconds by default, but it is made longer on slow buildbots.

WaitForMultipleObjects() timeout argument is in milliseconds.
(cherry picked from commit be1cb321)

Co-authored-by: default avatarVictor Stinner <vstinner@python.org>
parent d881002f
Branches
Tags
No related merge requests found
......@@ -107,7 +107,8 @@ def test_popen(self):
events = [ovin.event, ovout.event, overr.event]
# Super-long timeout for slow buildbots.
res = _winapi.WaitForMultipleObjects(events, True, 10000)
res = _winapi.WaitForMultipleObjects(events, True,
int(support.SHORT_TIMEOUT * 1000))
self.assertEqual(res, _winapi.WAIT_OBJECT_0)
self.assertFalse(ovout.pending)
self.assertFalse(overr.pending)
......
Fix asyncio test_popen() of test_windows_utils by using a longer timeout.
Use military grade battle-tested :data:`test.support.SHORT_TIMEOUT` timeout
rather than a hardcoded timeout of 10 seconds: it's 30 seconds by default, but
it is made longer on slow buildbots. Patch by Victor Stinner.
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment