Skip to content
Snippets Groups Projects
Unverified Commit 6fde2937 authored by Gregory P. Smith's avatar Gregory P. Smith Committed by GitHub
Browse files

[3.7] fix CI on macOS due to infrastructure changes (GH-96493)

* Add ABI and generated files checks to CI.

This includes checking in an initial Abigail ABI definition for 3.7.

* Backport ctypes test_macholib fix from b29d0a5a.

This is required for the 3.7 tree to pass on modern macOS.

* annotate test_bad_password @requires_zlib.

I don't know why, but macOS in 3.7 CI is failing to build the zlib
module these days so it's exposing this test that didn't have the
proper `@requires_zlib` annotation.

Getting it to build with zlib and other things that are now wrongly
"missing" in the 3.7 CI setup would be nice, but probably involves
invasive backporting of parts of
https://github.com/python/cpython/commit/b29d0a5a7811418c0a1082ca188fd4850185e290
by a macOS domain expert.

Not worth it.

* disable MachOTest.test_find unless macOS 11+ support is backported.

This test also appears to require changes to
Lib/ctypes/macholib/dyld.py to work in the existing macOS CI config.
I'm just skipping it, backporting that would be a feature.
Not going to happen in 3.7.

There may be a way to configure macOS CI to use an older macOS and
toolchain instead as an alternate option.  Someone else can figure
that out if so.  This branch only lives for another 9 months per
https://peps.python.org/pep-0537/



* LOL at my typo

Co-authored-by: default avatarNed Deily <nad@python.org>
parent 9d58933c
Branches
Tags
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment