Skip to content
Snippets Groups Projects
Unverified Commit b382bf50 authored by Miss Islington (bot)'s avatar Miss Islington (bot) Committed by GitHub
Browse files

gh-93156 - fix negative indexing into absolute `pathlib.PurePath().parents` (GH-93273)



When a `_PathParents` object has a drive or a root, the length of the
object is *one less* than than the length of `self._parts`, which resulted
in an off-by-one error when `path.parents[-n]` was fed through to
`self._parts[:-n - 1]`. In particular, `path.parents[-1]` was a malformed
path object with spooky properties.

This is addressed by adding `len(self)` to negative indices.
(cherry picked from commit f32e6b48)

Co-authored-by: default avatarBarney Gale <barney.gale@gmail.com>
parent 9cdfd1b0
Branches
Tags
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment