Skip to content
Snippets Groups Projects
Commit 5c270f76 authored by Tobias Hahn's avatar Tobias Hahn Committed by Mark Mentovai
Browse files

Fix incorrect depfile path relativization

While 'gyp dictates that commands are run from the base directory'
(ninja.py:1613), ninja still expects the depfile path for the depfile
that this command will create to be relative to the build directory.

If the depfile argument doesn't contain special paths like
<(PRODUCT_DIR), <(SHARED_INTERMEDIATE_DIR) or <(INTERMEDIATE_DIR),
ExpandSpecial returns its argument unchanged.

If it does contain one of these special paths, on the other hand, ninja
will never find the correct depfile without this fix.

Bug: 549
Change-Id: Idfae9dd1e7134720c5ce19fc8e4f877dde796d56
Reviewed-on: https://chromium-review.googlesource.com/c/external/gyp/+/1561250


Reviewed-by: default avatarMark Mentovai <mark@chromium.org>
parent 9f2a7bb1
Branches
Tags
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment