Skip to content
Snippets Groups Projects
Select Git revision
  • 5c270f76748e52bf8579316ee66b0facb4962628
  • master default protected
  • md-pages
  • infra/config
4 results

gyp

user avatar
Tobias Hahn authored and Mark Mentovai committed
While 'gyp dictates that commands are run from the base directory'
(ninja.py:1613), ninja still expects the depfile path for the depfile
that this command will create to be relative to the build directory.

If the depfile argument doesn't contain special paths like
<(PRODUCT_DIR), <(SHARED_INTERMEDIATE_DIR) or <(INTERMEDIATE_DIR),
ExpandSpecial returns its argument unchanged.

If it does contain one of these special paths, on the other hand, ninja
will never find the correct depfile without this fix.

Bug: 549
Change-Id: Idfae9dd1e7134720c5ce19fc8e4f877dde796d56
Reviewed-on: https://chromium-review.googlesource.com/c/external/gyp/+/1561250


Reviewed-by: default avatarMark Mentovai <mark@chromium.org>
5c270f76
History
Name Last commit Last update